Add `inventory-item-has-software-name` constraint #1038

Gabeblis · 2024-12-26T13:42:13Z

Committer Notes

Purpose

This PR aims to add the inventory-item-has-software-name constraint which ensures that every inventory items has a "os-name" or "software-name" prop

Changes

Added constraint:

inventory-item-has-software-name

Added valid/invalid test content:

ssp-inventory-item-has-software-name-INVALID.xml
Edited fedramp-ssp-example.oscal.xml to align with constraint

Added yaml files for testing:

Pass/fail yaml tests added for each of the above constraints.

All Submissions:

Have you selected the correct base branch per Contributing guidance?
Have you set "Allow edits and access to secrets by maintainers"?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you squashed any non-relevant commits and commit messages? [instructions]
Have you added an explanation of what your changes do and why you'd like us to include them?
If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.?
If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

kyhu65867

It looks fun to deal with all the merge conflicts from your last three PRs :) may be easier to just submit all at once?

aj-stein-gsa · 2024-12-27T15:16:45Z

src/validations/constraints/fedramp-external-constraints.xml

+        <metapath target="/system-security-plan/system-implementation/inventory-item"/>
+        <constraints>
+            <let var ="component-uuid" expression="implemented-component/@component-uuid"/>
+            <expect id="inventory-item-has-software-name" target=".[prop[@name='asset-type' and @value=('operating-system', 'container', 'image')] or ../component[uuid=$component-uuid and type='software']]" test="count(prop[@name=('software-name', 'os-name')]) >= 1 or count(../component[@uuid=$component-uuid]/prop[@name=('software-name', 'os-name')]) >= 1" level="ERROR">


Much like my other question for a related PR, what are we to do with with multiple concurrent OS/software names for a given inventory item?

May need to adjust the constraint. We do not expect more than one OS or software name for a particular inventory item. However, for a given inventory item, the "os-name" or "software-name" prop could exist:

in the inventory-item

in the referenced component

in both the inventory-item or the component it references

So in scenario 3, collectively, there could be more than one prop, however individually (scenarios 1 and 2) each would only have one prop.

I adjusted the test to only check for one prop and it does also handle scenario 3 properly.

Gabeblis · 2024-12-30T14:51:45Z

@Rene2mt As of right now, upstream allowed-values don't allow for a 'software-name' prop in a component. Tests fail when I try to add the example of an inventory-item not having the prop, but the linked component does have it.

Rene2mt

Looks good!! Nice work.

Rene2mt · 2024-12-31T15:47:24Z

@Rene2mt As of right now, upstream allowed-values don't allow for a 'software-name' prop in a component. Tests fail when I try to add the example of an inventory-item not having the prop, but the linked component does have it.

@Gabeblis , @aj-stein-gsa and @brian-ruf and I were just chatting about this. The are a couple of possible approaches:

We add a FedRAMP extension that would apply only to the component, and adjust the constraint accordingly
We add a FedRAMP extension that would apply to both the component and inventory-item instead of the core prop, and adjust the constraint accordingly
We submit an issue with NIST to add/allow the "software-name" prop in a component

Lets discuss in parking lot after standup today.

aj-stein-gsa · 2024-12-31T23:09:22Z

@Gabeblis , @aj-stein-gsa and @brian-ruf and I were just chatting about this. The are a couple of possible approaches:

We add a FedRAMP extension that would apply only to the component, and adjust the constraint accordingly

We add a FedRAMP extension that would apply to both the component and inventory-item instead of the core prop, and adjust the constraint accordingly

We submit an issue with NIST to add/allow the "software-name" prop in a component

Lets discuss in parking lot after standup today.

I am not sure where we landed officially, but we can work 3. The question is how we handle doing 1+3, 2+3, or wait out only 3. 3 is pending an issue from one of us (I have to check with @brian-ruf if I misunderstood, perhaps I needed to make that issue).

Seems like until Thursday we make this issue as blocked until we make a move. I agreed with sentiment you relayed to me before standup today, @Rene2mt, it may require parking the work (even before hitting develop) lest we confuse pilot participants and the large community of adopters before a candidate or final release.

brian-ruf · 2024-12-31T23:20:29Z

I took the action to make that issue and it's half written. We went out and I had an "oh shoot" moment when I realized I hadn't finished/saved it. Will get it submitted in the next 18 hours

brian-ruf · 2025-01-07T16:14:45Z

Opened usnistgov/OSCAL#2092 in the NIST OSCAL repo on Jan 1.

commit 7c6b0f2 Merge: f10ace6 26f4f19 Author: ~ . ~ <[email protected]> Date: Fri Jan 10 11:49:42 2025 -0500 Merge branch 'canary' of https://github.com/wandmagic/fedramp-automation into canary commit f10ace6 Author: ~ . ~ <[email protected]> Date: Wed Jan 8 11:06:00 2025 -0500 use latest server build commit d7af65c Author: ~ . ~ <[email protected]> Date: Tue Jan 7 22:21:48 2025 -0500 hotfix missing expect tag commit ee65d47 Author: ~ . ~ <[email protected]> Date: Tue Jan 7 17:17:54 2025 -0500 use preview versions of oscal tools commit b9ca17a Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:12:47 2025 -0500 Add 'inventory-item-has-software-name' constraint and tests (GSA#1038) commit f556138 Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:11:13 2025 -0500 Add `inventory-item-has-software-version` constraint (GSA#1039) * Add 'inventory-item-has-software-version' constraint and tests * Add 'inventory-item-has-software-version' constraint and tests commit 60ba7f7 Author: wandmagic <[email protected]> Date: Fri Jan 10 11:15:47 2025 -0500 add inventory item constraints (GSA#1063) * add inventory item constraints * update example file Co-Authored-By: A.J. Stein <[email protected]> * improve scan type constraint * massage constraints * improve constraint content * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: Gabeblis <[email protected]> * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: Gabeblis <[email protected]> * Update fedramp-external-constraints.xml * Update fedramp-external-constraints.xml * Squashed commit of the following: commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064) * Squashed commit of the following: commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (GSA#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (GSA#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064) * Squashed commit of the following: commit 8c1a343 Author: Gabeblis <[email protected]> Date: Thu Jan 9 11:45:37 2025 -0500 Add new metapath target to 'security-level' constraint (GSA#1079) commit 608080d Author: wandmagic <[email protected]> Date: Thu Jan 9 09:29:17 2025 -0500 add additional sample content (GSA#1081) commit 1f55a73 Author: Gabeblis <[email protected]> Date: Thu Jan 9 09:22:28 2025 -0500 Correct constraint message. (GSA#1085) commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (GSA#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (GSA#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064) --------- Co-authored-by: A.J. Stein <[email protected]> Co-authored-by: Gabeblis <[email protected]> commit 5e3f386 Author: wandmagic <[email protected]> Date: Fri Jan 10 09:25:07 2025 -0500 make build (GSA#1080) commit 8c1a343 Author: Gabeblis <[email protected]> Date: Thu Jan 9 11:45:37 2025 -0500 Add new metapath target to 'security-level' constraint (GSA#1079) commit 608080d Author: wandmagic <[email protected]> Date: Thu Jan 9 09:29:17 2025 -0500 add additional sample content (GSA#1081) commit 1f55a73 Author: Gabeblis <[email protected]> Date: Thu Jan 9 09:22:28 2025 -0500 Correct constraint message. (GSA#1085) commit 26f4f19 Author: ~ . ~ <[email protected]> Date: Wed Jan 8 11:06:00 2025 -0500 use latest server build commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (GSA#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (GSA#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit dd20034 Author: ~ . ~ <[email protected]> Date: Tue Jan 7 22:21:48 2025 -0500 hotfix missing expect tag commit b4d3df5 Author: ~ . ~ <[email protected]> Date: Tue Jan 7 17:17:54 2025 -0500 use preview versions of oscal tools commit 719cf2c Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:12:47 2025 -0500 Add 'inventory-item-has-software-name' constraint and tests (GSA#1038) commit ec7affc Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:11:13 2025 -0500 Add `inventory-item-has-software-version` constraint (GSA#1039) * Add 'inventory-item-has-software-version' constraint and tests * Add 'inventory-item-has-software-version' constraint and tests

commit 7c6b0f2 Merge: f10ace6 26f4f19 Author: ~ . ~ <[email protected]> Date: Fri Jan 10 11:49:42 2025 -0500 Merge branch 'canary' of https://github.com/wandmagic/fedramp-automation into canary commit f10ace6 Author: ~ . ~ <[email protected]> Date: Wed Jan 8 11:06:00 2025 -0500 use latest server build commit d7af65c Author: ~ . ~ <[email protected]> Date: Tue Jan 7 22:21:48 2025 -0500 hotfix missing expect tag commit ee65d47 Author: ~ . ~ <[email protected]> Date: Tue Jan 7 17:17:54 2025 -0500 use preview versions of oscal tools commit b9ca17a Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:12:47 2025 -0500 Add 'inventory-item-has-software-name' constraint and tests (GSA#1038) commit f556138 Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:11:13 2025 -0500 Add `inventory-item-has-software-version` constraint (GSA#1039) * Add 'inventory-item-has-software-version' constraint and tests * Add 'inventory-item-has-software-version' constraint and tests commit 60ba7f7 Author: wandmagic <[email protected]> Date: Fri Jan 10 11:15:47 2025 -0500 add inventory item constraints (GSA#1063) * add inventory item constraints * update example file Co-Authored-By: A.J. Stein <[email protected]> * improve scan type constraint * massage constraints * improve constraint content * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: Gabeblis <[email protected]> * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: Gabeblis <[email protected]> * Update fedramp-external-constraints.xml * Update fedramp-external-constraints.xml * Squashed commit of the following: commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064) * Squashed commit of the following: commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (GSA#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (GSA#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064) * Squashed commit of the following: commit 8c1a343 Author: Gabeblis <[email protected]> Date: Thu Jan 9 11:45:37 2025 -0500 Add new metapath target to 'security-level' constraint (GSA#1079) commit 608080d Author: wandmagic <[email protected]> Date: Thu Jan 9 09:29:17 2025 -0500 add additional sample content (GSA#1081) commit 1f55a73 Author: Gabeblis <[email protected]> Date: Thu Jan 9 09:22:28 2025 -0500 Correct constraint message. (GSA#1085) commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (GSA#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (GSA#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064) --------- Co-authored-by: A.J. Stein <[email protected]> Co-authored-by: Gabeblis <[email protected]> commit 5e3f386 Author: wandmagic <[email protected]> Date: Fri Jan 10 09:25:07 2025 -0500 make build (GSA#1080) commit 8c1a343 Author: Gabeblis <[email protected]> Date: Thu Jan 9 11:45:37 2025 -0500 Add new metapath target to 'security-level' constraint (GSA#1079) commit 608080d Author: wandmagic <[email protected]> Date: Thu Jan 9 09:29:17 2025 -0500 add additional sample content (GSA#1081) commit 1f55a73 Author: Gabeblis <[email protected]> Date: Thu Jan 9 09:22:28 2025 -0500 Correct constraint message. (GSA#1085) commit 26f4f19 Author: ~ . ~ <[email protected]> Date: Wed Jan 8 11:06:00 2025 -0500 use latest server build commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (GSA#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (GSA#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit dd20034 Author: ~ . ~ <[email protected]> Date: Tue Jan 7 22:21:48 2025 -0500 hotfix missing expect tag commit b4d3df5 Author: ~ . ~ <[email protected]> Date: Tue Jan 7 17:17:54 2025 -0500 use preview versions of oscal tools commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit 719cf2c Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:12:47 2025 -0500 Add 'inventory-item-has-software-name' constraint and tests (GSA#1038) commit ec7affc Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:11:13 2025 -0500 Add `inventory-item-has-software-version` constraint (GSA#1039) * Add 'inventory-item-has-software-version' constraint and tests * Add 'inventory-item-has-software-version' constraint and tests commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064) commit d8a9ec9 Author: DimitriZhurkin <[email protected]> Date: Fri Jan 3 11:20:23 2025 -0700 Add connection-security constraint (issue GSA#961) (GSA#1021) * Add connection-security constraint (issue GSA#961) * change fedramp ns to http * Add help-url commit 1648871 Author: Kylie Hunter <[email protected]> Date: Fri Jan 3 13:02:59 2025 -0500 Image has checksum (GSA#1053) * test scaffolds added * initial attempt at writing pass and fail content * feature file * revised target to appropriate place * removed old target * added in proper ns * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: A.J. Stein <[email protected]> * AJ suggestion for more complete example * added comments --------- Co-authored-by: A.J. Stein <[email protected]> commit 962a9c0 Author: Gabeblis <[email protected]> Date: Fri Jan 3 12:31:04 2025 -0500 Add 'inventory-item-or-component-has-asset-id' constraint and tests (GSA#1056) commit 836b224 Author: Rene Tshiteya <[email protected]> Date: Fri Jan 3 12:25:35 2025 -0500 Fix implemented-component component-uuid references (GSA#1059) Fix component issues commit 7018c20 Author: Gabeblis <[email protected]> Date: Fri Jan 3 12:24:47 2025 -0500 Add 'inventory-item-has-valid-mac-address' constraint and tests (GSA#1057)

commit 719cf2c Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:12:47 2025 -0500 Add 'inventory-item-has-software-name' constraint and tests (GSA#1038) commit ec7affc Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:11:13 2025 -0500 Add `inventory-item-has-software-version` constraint (GSA#1039) * Add 'inventory-item-has-software-version' constraint and tests * Add 'inventory-item-has-software-version' constraint and tests commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064) commit d8a9ec9 Author: DimitriZhurkin <[email protected]> Date: Fri Jan 3 11:20:23 2025 -0700 Add connection-security constraint (issue GSA#961) (GSA#1021) * Add connection-security constraint (issue GSA#961) * change fedramp ns to http * Add help-url commit 1648871 Author: Kylie Hunter <[email protected]> Date: Fri Jan 3 13:02:59 2025 -0500 Image has checksum (GSA#1053) * test scaffolds added * initial attempt at writing pass and fail content * feature file * revised target to appropriate place * removed old target * added in proper ns * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: A.J. Stein <[email protected]> * AJ suggestion for more complete example * added comments --------- Co-authored-by: A.J. Stein <[email protected]> commit 962a9c0 Author: Gabeblis <[email protected]> Date: Fri Jan 3 12:31:04 2025 -0500 Add 'inventory-item-or-component-has-asset-id' constraint and tests (GSA#1056) commit 836b224 Author: Rene Tshiteya <[email protected]> Date: Fri Jan 3 12:25:35 2025 -0500 Fix implemented-component component-uuid references (GSA#1059) Fix component issues commit 7018c20 Author: Gabeblis <[email protected]> Date: Fri Jan 3 12:24:47 2025 -0500 Add 'inventory-item-has-valid-mac-address' constraint and tests (GSA#1057)

* fix constraints (#1070) * use preview versions of oscal tools * hotfix missing expect tag * Add the inter-boundary-component-has-information-type constraint (#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml * Hotfix styles (#1076) * style guide hotfix * Update fedramp-external-constraints.xml * use latest server build * Correct constraint message. (#1085) * add additional sample content (#1081) * Add new metapath target to 'security-level' constraint (#1079) * make build (#1080) * add inventory item constraints (#1063) * add inventory item constraints * update example file Co-Authored-By: A.J. Stein <[email protected]> * improve scan type constraint * massage constraints * improve constraint content * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: Gabeblis <[email protected]> * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: Gabeblis <[email protected]> * Update fedramp-external-constraints.xml * Update fedramp-external-constraints.xml * Squashed commit of the following: commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (#1064) * Squashed commit of the following: commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (#1064) * Squashed commit of the following: commit 8c1a343 Author: Gabeblis <[email protected]> Date: Thu Jan 9 11:45:37 2025 -0500 Add new metapath target to 'security-level' constraint (#1079) commit 608080d Author: wandmagic <[email protected]> Date: Thu Jan 9 09:29:17 2025 -0500 add additional sample content (#1081) commit 1f55a73 Author: Gabeblis <[email protected]> Date: Thu Jan 9 09:22:28 2025 -0500 Correct constraint message. (#1085) commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (#1064) --------- Co-authored-by: A.J. Stein <[email protected]> Co-authored-by: Gabeblis <[email protected]> * Add `inventory-item-has-software-version` constraint (#1039) * Add 'inventory-item-has-software-version' constraint and tests * Add 'inventory-item-has-software-version' constraint and tests * Add 'inventory-item-has-software-name' constraint and tests (#1038) * use preview versions of oscal tools * hotfix missing expect tag * use latest server build * fix order and missing expect closing tag * Update fedramp-external-constraints.xml * use versions matrix for snapshot testing This reverts commit 5679abd. * better action names * Update module.mk * Update .tool-versions --------- Co-authored-by: DimitriZhurkin <[email protected]> Co-authored-by: Gabeblis <[email protected]> Co-authored-by: A.J. Stein <[email protected]>

Gabeblis self-assigned this Dec 26, 2024

Gabeblis requested a review from a team as a code owner December 26, 2024 13:42

Gabeblis force-pushed the constraints/issue-1035 branch from a14449a to 33765c4 Compare December 26, 2024 13:50

kyhu65867 previously approved these changes Dec 26, 2024

View reviewed changes

Gabeblis changed the title ~~Add inventory-item-has-software-name constraint~~ [DO NOT MERGE] Add inventory-item-has-software-name constraint Dec 26, 2024

Gabeblis dismissed kyhu65867’s stale review via 7b73b99 December 26, 2024 16:20

Gabeblis force-pushed the constraints/issue-1035 branch 2 times, most recently from 7b73b99 to 8db30c9 Compare December 26, 2024 18:17

Gabeblis linked an issue Dec 26, 2024 that may be closed by this pull request

Inventory - OS or Software Name #1035

Open

15 tasks

Gabeblis force-pushed the constraints/issue-1035 branch from 8db30c9 to 9e60aaa Compare December 27, 2024 15:08

aj-stein-gsa reviewed Dec 27, 2024

View reviewed changes

Gabeblis force-pushed the constraints/issue-1035 branch from 9e60aaa to 0481e2c Compare December 27, 2024 22:34

Gabeblis changed the title ~~[DO NOT MERGE] Add inventory-item-has-software-name constraint~~ Add inventory-item-has-software-name constraint Dec 29, 2024

Gabeblis requested review from kyhu65867, Rene2mt and aj-stein-gsa December 30, 2024 15:16

Gabeblis force-pushed the constraints/issue-1035 branch from 0481e2c to 8164d55 Compare December 30, 2024 15:34

Rene2mt previously approved these changes Dec 30, 2024

View reviewed changes

Gabeblis dismissed Rene2mt’s stale review via 239ee45 December 30, 2024 19:13

Gabeblis force-pushed the constraints/issue-1035 branch from 8164d55 to 239ee45 Compare December 30, 2024 19:13

Rene2mt mentioned this pull request Dec 31, 2024

Add inventory-item-has-software-version constraint #1039

Merged

7 tasks

This was referenced Dec 31, 2024

Inventory - OS or Software Name #1035

Open

Inventory - OS or Software Version #1036

Open

Add 'inventory-item-has-software-name' constraint and tests

20eb0a5

Gabeblis force-pushed the constraints/issue-1035 branch from 239ee45 to 20eb0a5 Compare January 6, 2025 12:03

Gabeblis changed the base branch from develop to canary January 7, 2025 18:08

Merge branch 'canary' into constraints/issue-1035

f1f1e0b

Gabeblis merged commit 719cf2c into GSA:canary Jan 7, 2025
3 of 6 checks passed

wandmagic pushed a commit to wandmagic/fedramp-automation that referenced this pull request Jan 10, 2025

Add 'inventory-item-has-software-name' constraint and tests (GSA#1038)

b9ca17a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `inventory-item-has-software-name` constraint #1038

Add `inventory-item-has-software-name` constraint #1038

Gabeblis commented Dec 26, 2024 •

edited

Loading

kyhu65867 left a comment

aj-stein-gsa Dec 27, 2024

Rene2mt Dec 27, 2024

Gabeblis Dec 27, 2024

Gabeblis commented Dec 30, 2024

Rene2mt left a comment

Rene2mt commented Dec 31, 2024

aj-stein-gsa commented Dec 31, 2024

brian-ruf commented Dec 31, 2024

brian-ruf commented Jan 7, 2025

Add inventory-item-has-software-name constraint #1038

Add inventory-item-has-software-name constraint #1038

Conversation

Gabeblis commented Dec 26, 2024 • edited Loading

Committer Notes

Purpose

Changes

All Submissions:

kyhu65867 left a comment

Choose a reason for hiding this comment

aj-stein-gsa Dec 27, 2024

Choose a reason for hiding this comment

Rene2mt Dec 27, 2024

Choose a reason for hiding this comment

Gabeblis Dec 27, 2024

Choose a reason for hiding this comment

Gabeblis commented Dec 30, 2024

Rene2mt left a comment

Choose a reason for hiding this comment

Rene2mt commented Dec 31, 2024

aj-stein-gsa commented Dec 31, 2024

brian-ruf commented Dec 31, 2024

brian-ruf commented Jan 7, 2025

Add `inventory-item-has-software-name` constraint #1038

Add `inventory-item-has-software-name` constraint #1038

Gabeblis commented Dec 26, 2024 •

edited

Loading